Skip to content

test(nextjs): add e2e tests for app router #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aymeric-giraudet
Copy link
Member

@aymeric-giraudet aymeric-giraudet commented Jun 24, 2025

Still part of FX-3392

@aymeric-giraudet aymeric-giraudet requested review from a team, dhayab and Haroenv and removed request for a team June 24, 2025 09:03
Copy link

codesandbox-ci bot commented Jun 24, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@aymeric-giraudet aymeric-giraudet force-pushed the test/nextjs-app-router-e2e branch from 4a45068 to 73e64bf Compare June 24, 2025 09:53
@aymeric-giraudet aymeric-giraudet requested a review from Haroenv June 26, 2025 13:23
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a different iteration we probably want to split the example for tests + the example for documentation, but this makes sense for now

@aymeric-giraudet aymeric-giraudet merged commit 077a6d3 into feat/nextjs-multiple-hooks Jun 27, 2025
10 checks passed
@aymeric-giraudet aymeric-giraudet deleted the test/nextjs-app-router-e2e branch June 27, 2025 08:25
aymeric-giraudet added a commit that referenced this pull request Jun 27, 2025
* feat(nextjs): add a `skipSuspense` arg to allow hook composition

* test(nextjs): add e2e tests for app router (#6661)

* test(nextjs): add e2e tests for app router

* fix tests

* add option to ignore warning
aymeric-giraudet added a commit that referenced this pull request Jul 8, 2025
…mounts (#6647)

BREAKING CHANGE

* feat(nextjs): add an `instance` prop to keep same instance across remounts

* feat(nextjs): add a `skipSuspense` arg to allow hook composition (#6660)

* feat(nextjs): add a `skipSuspense` arg to allow hook composition

* test(nextjs): add e2e tests for app router (#6661)

* test(nextjs): add e2e tests for app router

* fix tests

* add option to ignore warning

* update links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants