fix: return waitForIndexer when latest lastValid is reached #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a fix for #363 by ensuring that waitForIndexer returns as soon as the last valid round is reached, avoiding an unnecessary 20-second wait.
- Introduces a new private helper method (_pushTxn) to update the _latestLastValidRound and log transaction IDs.
- Modifies logRawTransaction to use _pushTxn for both single and multiple transactions.
- Updates waitForIndexer to catch lookup errors and conditionally check the last valid round, and refreshes documentation accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/testing/transaction-logger.ts | Refactored transaction logging and indexer waiting logic. |
| docs/code/classes/testing.TransactionLogger.md | Updated documentation to include new private members and methods. |
Co-authored-by: Copilot <[email protected]>
neilcampbell
approved these changes
Jun 5, 2025
| // If that round exists, then we know indexer is caught up | ||
| if (this._latestLastValidRound) { | ||
| await indexer.lookupBlock(this._latestLastValidRound).do() | ||
| console.debug( |
There was a problem hiding this comment.
Suggested change
| console.debug( | |
| Config.getLogger().debug( |
Will also need the Config import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix for #363
Basically avoids waiting for 20 seconds once it becomes impossible for the transaction to get indexed