fix: added fixes for flutter 3.22 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ali-thowfeek Bumping this, as our project depends on it as well |
LeNeuner
approved these changes
May 15, 2024
|
I really need this fix too! |
|
I need this PR to be merged and released too! 🙏 |
iharoonamjad
approved these changes
May 17, 2024
ali-thowfeek
requested changes
May 18, 2024
There was a problem hiding this comment.
@erickgon92 Thank you for the PR. Really appreciate the time you put in 😇. There are few things we need to get right before we can go ahead with this PR.
Font sizes reference:
https://github.com/flutter/flutter/blob/5dcb86f68f239346676ceb1ed1ea385bd215fba1/packages/flutter/lib/src/material/text_theme.dart
| @@ -161,7 +160,7 @@ class Parser { | |||
| case 'h1': | |||
| double h1; | |||
| if (defaultFontSize == null) { | |||
| h1 = Theme.of(context).textTheme.headline5?.fontSize ?? 24.0; | |||
| h1 = Theme.of(context).textTheme.headlineLarge?.fontSize ?? 24.0; | |||
| @@ -171,7 +170,7 @@ class Parser { | |||
| case 'h2': | |||
| double h2; | |||
| if (defaultFontSize == null) { | |||
| h2 = Theme.of(context).textTheme.headline6?.fontSize ?? 20.0; | |||
| h2 = Theme.of(context).textTheme.headlineLarge?.fontSize ?? 20.0; | |||
| @@ -181,7 +180,7 @@ class Parser { | |||
| case 'h3': | |||
| double h3; | |||
| if (defaultFontSize == null) { | |||
| h3 = Theme.of(context).textTheme.subtitle1?.fontSize ?? 16.0; | |||
| h3 = Theme.of(context).textTheme.headlineMedium?.fontSize ?? 16.0; | |||
| @@ -191,7 +190,7 @@ class Parser { | |||
| case 'h4': | |||
| double h4; | |||
| if (defaultFontSize == null) { | |||
| h4 = Theme.of(context).textTheme.bodyText1?.fontSize ?? 16.0; | |||
| h4 = Theme.of(context).textTheme.headlineMedium?.fontSize ?? 16.0; | |||
| @@ -201,7 +200,7 @@ class Parser { | |||
| case 'h5': | |||
| double h5; | |||
| if (defaultFontSize == null) { | |||
| h5 = Theme.of(context).textTheme.bodyText1?.fontSize ?? 16.0; | |||
| h5 = Theme.of(context).textTheme.headlineMedium?.fontSize ?? 16.0; | |||
| @@ -211,7 +210,7 @@ class Parser { | |||
| case 'h6': | |||
| double h6; | |||
| if (defaultFontSize == null) { | |||
| h6 = Theme.of(context).textTheme.bodyText2?.fontSize ?? 14.0; | |||
| h6 = Theme.of(context).textTheme.headlineSmall?.fontSize ?? 14.0; | |||
|
Thank you all for your time!! I will make the fixes and inform you. Cheers all! |
|
@erickgon92 I've already merged your PR. Made the necessary changes on top myself. So no more changes needed on your part. New version 5.0.0 released. Thank you once again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated libraries and fixed all necessary lines where the deprecated elements where being used.