refactor(TimePicker2): convert to TypeScript, impove docs and tests, close #4616 #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FairyYang
force-pushed
the
refactor-ts-timepicker2
branch
from
f55f6b6
to
86aca9f
Compare
这个只是描述一个事实，问题是什么？ |
|
问题是，disabledHours在旧的doc里，类型是 (index?: number) => boolean，新增的类型是：(index?: number) => boolean | number[] |
以实际的实现逻辑为准 |
eternalsky
requested changes
Oct 12, 2024
eternalsky
requested changes
Oct 12, 2024
FairyYang
force-pushed
the
refactor-ts-timepicker2
branch
from
86aca9f
to
a83c38f
Compare
eternalsky
reviewed
Oct 16, 2024
eternalsky
requested changes
Oct 16, 2024
FairyYang
force-pushed
the
refactor-ts-timepicker2
branch
2 times, most recently
from
30e2760
to
7006e77
Compare
eternalsky
requested changes
Oct 17, 2024
|
针对最后一个问题的回复：handleChange 里 v 不可以是 string，在VSCODE里，没有as ValueType，不会报错。 |
FairyYang
force-pushed
the
refactor-ts-timepicker2
branch
from
7006e77
to
a07a4db
Compare
eternalsky
requested changes
Oct 18, 2024
FairyYang
force-pushed
the
refactor-ts-timepicker2
branch
from
a07a4db
to
a2d3a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
遇到个问题，当type: range时，disabledHours 需要返回number[]，panel的代码逻辑是这么实现的。实际使用过，确实如此。