Skip to content

chore: upgrade deps version and using v20,22 of nodejs in CI #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ianzone
Copy link
Contributor

@ianzone ianzone commented Jul 5, 2025

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?) pnpm, node, biome update

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English upgrade deps version and using v20,22 of nodejs in CI
🇨🇳 Chinese 升级依赖版本,再 CI 中使用20,22版本的nodejs

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ianzone
Copy link
Contributor Author

ianzone commented Jul 6, 2025

@li-jia-nan HI,可否帮忙审一下,谢谢

@li-jia-nan
Copy link
Collaborator

biome 支持 md 吗?要不要把 prettier 也加上?
@crazylxr @liuyib 一起看下

@ianzone
Copy link
Contributor Author

ianzone commented Jul 6, 2025

biome 支持 md 吗?要不要把 prettier 也加上? @crazylxr @liuyib 一起看下

md 在 biome 的支持路径中 https://biomejs.dev/internals/language-support/ ,prettier 就不加了吧,会增加依赖还要维护两组格式化规则

@liuyib
Copy link
Collaborator

liuyib commented Jul 6, 2025 via email

@ianzone
Copy link
Contributor Author

ianzone commented Jul 6, 2025

不加的话现在用什么格式化md?有推荐的方法吗

------------------ Original ------------------ From: Yiheng @.> Date: Sun,Jul 6,2025 1:32 PM To: alibaba/hooks @.> Cc: 云泥 @.>, Mention @.> Subject: Re: [alibaba/hooks] pnpm update (PR #2800) ianzone left a comment (alibaba/hooks#2800) biome 支持 md 吗?要不要把 prettier 也加上? @crazylxr @liuyib 一起看下 md 在 biome 的支持路径中 https://biomejs.dev/internals/language-support/ ,prettier 就不加了吧,会增加依赖还要维护两组格式化规则 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

用 IDE 自带的 md 格式化功能即可,vscode 就有。当然如果 IDE 没有这个功能就不会格式化,但 md 并没有源码文件的重要性高,所以可以先不管它,等biome支持就好。

@ianzone
Copy link
Contributor Author

ianzone commented Jul 6, 2025

不加的话现在用什么格式化md?有推荐的方法吗

------------------ Original ------------------ From: Yiheng @.> Date: Sun,Jul 6,2025 1:32 PM To: alibaba/hooks @.> Cc: 云泥 @.>, Mention @.> Subject: Re: [alibaba/hooks] pnpm update (PR #2800) ianzone left a comment (alibaba/hooks#2800) biome 支持 md 吗?要不要把 prettier 也加上? @crazylxr @liuyib 一起看下 md 在 biome 的支持路径中 https://biomejs.dev/internals/language-support/ ,prettier 就不加了吧,会增加依赖还要维护两组格式化规则 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

editorconfig 里有 md 的格式规则

@liuyib
Copy link
Collaborator

liuyib commented Jul 6, 2025

不加的话现在用什么格式化md?有推荐的方法吗

------------------ Original ------------------ From: Yiheng @.> Date: Sun,Jul 6,2025 1:32 PM To: alibaba/hooks _@**._> Cc: 云泥 _@.>, Mention @._> Subject: Re: [alibaba/hooks] pnpm update (PR #2800) ianzone left a comment (alibaba/hooks#2800) biome 支持 md 吗?要不要把 prettier 也加上? @crazylxr @liuyib 一起看下 md 在 biome 的支持路径中 biomejs.dev/internals/language-support ,prettier 就不加了吧,会增加依赖还要维护两组格式化规则 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: _@_.*>

用 IDE 自带的 md 格式化功能即可,vscode 就有。当然如果 IDE 没有这个功能就不会格式化,但 md 并没有源码文件的重要性高,所以可以先不管它,等biome支持就好。

IDE 自带格式不太行,每个人自己的配置不同,格式统一性没法保证,每个人格式出来的结果变来变去的,还是要管一下 md 的格式化的,你不想弄的话,不在这个 PR 里加了,我单开 PR 搞。

@ianzone
Copy link
Contributor Author

ianzone commented Jul 6, 2025

不加的话现在用什么格式化md?有推荐的方法吗

------------------ Original ------------------ From: Yiheng @.> Date: Sun,Jul 6,2025 1:32 PM To: alibaba/hooks _@**._> Cc: 云泥 _@.>, Mention @._> Subject: Re: [alibaba/hooks] pnpm update (PR #2800) ianzone left a comment (alibaba/hooks#2800) biome 支持 md 吗?要不要把 prettier 也加上? @crazylxr @liuyib 一起看下 md 在 biome 的支持路径中 biomejs.dev/internals/language-support ,prettier 就不加了吧,会增加依赖还要维护两组格式化规则 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: _@_.*>

用 IDE 自带的 md 格式化功能即可,vscode 就有。当然如果 IDE 没有这个功能就不会格式化,但 md 并没有源码文件的重要性高,所以可以先不管它,等biome支持就好。

IDE 自带格式不太行,每个人自己的配置不同,格式统一性没法保证,每个人格式出来的结果变来变去的,还是要管一下 md 的格式化的,你不想弄的话,不在这个 PR 里加了,我单开 PR 搞。

如果 editorconfig 还不够用的话那就单开PR吧

@liuyib
Copy link
Collaborator

liuyib commented Jul 6, 2025

不加的话现在用什么格式化md?有推荐的方法吗

------------------ Original ------------------ From: Yiheng @.> Date: Sun,Jul 6,2025 1:32 PM To: alibaba/hooks _@**._> Cc: 云泥 _@.>, Mention @._> Subject: Re: [alibaba/hooks] pnpm update (PR #2800) ianzone left a comment (alibaba/hooks#2800) biome 支持 md 吗?要不要把 prettier 也加上? @crazylxr @liuyib 一起看下 md 在 biome 的支持路径中 biomejs.dev/internals/language-support ,prettier 就不加了吧,会增加依赖还要维护两组格式化规则 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: _@_.*>

用 IDE 自带的 md 格式化功能即可,vscode 就有。当然如果 IDE 没有这个功能就不会格式化,但 md 并没有源码文件的重要性高,所以可以先不管它,等biome支持就好。

IDE 自带格式不太行,每个人自己的配置不同,格式统一性没法保证,每个人格式出来的结果变来变去的,还是要管一下 md 的格式化的,你不想弄的话,不在这个 PR 里加了,我单开 PR 搞。

如果 editorconfig 还不够用的话那就单开PR吧

包不够用的

@li-jia-nan
Copy link
Collaborator

开源项目肯定需要统一配置,不能让用户自己用 IDE 做 format,太不可控了

@liuyib liuyib requested review from crazylxr, liuyib and li-jia-nan July 6, 2025 07:17
@liuyib liuyib changed the title pnpm update chore: upgrade deps version and using v20,22 of nodejs in CI Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants