feat: Add inner processor to parse PipelineEventGroup pb #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eb5adfd.
Cirilla-zmh
force-pushed
the
feature/span_serializer
branch
from
0dbccf2 to
9795e83
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new inner processor, ProcessorParseFromPBNative, to parse PipelineEventGroup protobuf data and adds corresponding unit tests. Key changes include:
- Implementation of the processor in new header and source files.
- Addition of unit tests in ProcessorParseFromPBNativeUnittest.cpp covering valid, non-raw, and invalid events.
- Updates to the CMake build configuration to include the new test target.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/unittest/processor/ProcessorParseFromPBNativeUnittest.cpp | New unit tests for verifying processor behavior with various input cases |
| core/unittest/processor/CMakeLists.txt | Added executable and test discovery entry for the new processor |
| core/plugin/processor/inner/ProcessorParseFromPBNative.h | Declaration of the new processor with required interfaces |
| core/plugin/processor/inner/ProcessorParseFromPBNative.cpp | Implementation of processor parsing logic and event handling |
KayzzzZ
reviewed
Jun 17, 2025
Abingcbc
requested changes
Jun 17, 2025
Cirilla-zmh
changed the title
Cirilla-zmh
changed the title
Cirilla-zmh
changed the title
KayzzzZ
reviewed
Jun 18, 2025
KayzzzZ
approved these changes
Jun 19, 2025
linrunqi08
reviewed
Jul 7, 2025
| LOG_WARNING(sLogger, ("unsupported event type", "pipelineEventGroup is empty")); | ||
| return; | ||
| } | ||
| const auto& e = eventGroup.GetEvents().at(0); |
There was a problem hiding this comment.
这里可以看下ProcessorSPL，Process支持传入std::vector& logGroupList，一进多出。Events里面再设置只拿一个，不太合理
| if (pbGroup.ParseFromString(sourceEvent.GetContent().data())) { | ||
| eventGroup.MutableEvents().clear(); | ||
| TransferPBToPipelineEventGroup(pbGroup, eventGroup, errMsg); | ||
| } else { |
There was a problem hiding this comment.
这里else是不是可以和if (!errMsg.empty()) 合并起来，处理成功一个分支，其他是另一个分支。否则这里也是需要打印LOG_WARNING的
| UNIT_TEST_CASE(ProcessorParseFromPBNativeUnittest, TestProcessValidSpanData) | ||
| UNIT_TEST_CASE(ProcessorParseFromPBNativeUnittest, TestProcessNonRawEvent) | ||
| UNIT_TEST_CASE(ProcessorParseFromPBNativeUnittest, TestProcessInvalidProtobufData) | ||
|
|
There was a problem hiding this comment.
序列化我们认为是会比较耗时的话，建议这里加一个benchmark，可以参考SplBenchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.