feature: add net collector #2265
Open
+1,353
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new network metrics collector to the host monitoring system, adding both collection logic and unit tests, and wiring it into existing input and runner components.
- Added
NetCollectorclass for gathering network interface and TCP connection statistics. - Extended
SystemInterface(and its Linux implementation) with methods to fetch TCP and network-rate information. - Introduced
NetCollectorUnittestand updated CMake to build and run the new test. - Registered
NetCollectorin input/plugin components (InputHostMonitor.cpp,HostMonitorInputRunner.cpp).
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| core/host_monitor/collector/NetCollector.h | Declared new NetCollector API |
| core/host_monitor/collector/NetCollector.cpp | Implemented network-stat parsing and reporting |
| core/host_monitor/SystemInterface.{h,cpp} | Added GetTCPStatInformation* and GetNetRateInformation* |
| core/host_monitor/LinuxSystemInterface.cpp | Parsed /proc/net/sockstat* and /proc/net/dev |
| core/unittest/host_monitor/NetCollectorUnittest.cpp | Created unit tests for NetCollector |
Comments suppressed due to low confidence (1)
core/host_monitor/LinuxSystemInterface.cpp:411
- Consider adding unit tests for
GetTCPStatInformationOnceandGetNetRateInformationOnceto validate parsing logic against sample/proc/netdata.
bool LinuxSystemInterface::GetTCPStatInformationOnce(TCPStatInformation& tcpStatInfo) {
Abingcbc
requested changes
Jun 23, 2025
WRPStephanie
force-pushed
the
netmain
branch
5 times, most recently
from
8d188b7 to
e6d0981
Compare
Abingcbc
requested changes
Jul 12, 2025
|
|
||
| class NetCollectorUnittest : public ::testing::Test { | ||
| public: | ||
| void TestCollect() const; |
There was a problem hiding this comment.
没有异常情况的单测。
- ReadSocketStat函数测试
测试文件不存在的情况
测试文件格式错误的情况 - GetInterfaceConfig函数测试
测试网络接口不存在的情况
测试IPv4/IPv6地址解析 - ReadNetLink函数测试
测试netlink socket创建失败
测试消息发送/接收失败
测试TCP状态统计正确性 - 网络数据解析测试
测试/proc/net/dev文件格式变化
测试异常数据的处理
测试数值转换异常
There was a problem hiding this comment.
4. /proc/net/dev文件格式变化
已补充异常情况测试。读取的/proc/net/dev的内容长期保持不变，基本可以不考虑这种情况。
Abingcbc
approved these changes
Jul 21, 2025
| // ipv6 | ||
| std::vector<std::string> netInet6Lines = {}; | ||
| std::string errorMessage; | ||
| if (std::filesystem::exists(PROCESS_DIR / PROCESS_NET_IF_INET6)) { |
There was a problem hiding this comment.
有些地方是用CheckExistance，有些是用filesystem，是不是可以统一一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增采集网络指标的collector