-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[ui] Attribute / Node: Refacto of the attribute validation paradigm #2725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicolas-lambert-tc
wants to merge
13
commits into
develop
Choose a base branch
from
feature/node-valididy-check
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #2725 +/- ##
===========================================
+ Coverage 78.57% 78.89% +0.32%
===========================================
Files 48 50 +2
Lines 6577 6663 +86
===========================================
+ Hits 5168 5257 +89
+ Misses 1409 1406 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aca1a11
to
a6e26b9
Compare
458de57
to
404056d
Compare
528c611
to
2a34f27
Compare
…range icon if an error exists. Mandatory atribute have a '*'
…splays a warning icon, and selection border is orange
…idity. Id one is not valid an icon is added
…some atribute fields
Co-authored-by: Fabien Castan <[email protected]>
Co-authored-by: Fabien Castan <[email protected]>
7154a48
to
88227fb
Compare
88227fb
to
48acfec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alicevision related PR
Add a standard way to validate the attribute value.
It add a way to apply validators to an attribute description and to represent in the UI when these attributes are not valid.
Validators
Validators usage (can be a lambda)
Features list