Fix menu toggle behavior for gear icon buttons across UI components #2833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix SequencePlayer.qml infoButton to properly toggle menu on click - Fix WorkspaceView.qml imageViewer menu button for consistency - Change from always calling open() to conditional toggle logic Co-authored-by: fabiencastan <[email protected]>
- Fix Application.qml graphEditorMenu toggle - Fix ImageGallery.qml galleryMenu toggle - Fix NodeEditor.qml settingsMenu toggle - Apply consistent toggle pattern across all menu buttons Co-authored-by: fabiencastan <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
fabiencastan
August 17, 2025 22:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu buttons with gear icons (⚙️) throughout the Meshroom UI were not closing when clicked a second time, requiring users to click elsewhere to dismiss menus. The root cause was that
onClickedhandlers were always callingmenu.open()instead of implementing proper toggle behavior.Problem
When clicking any gear icon menu button:
Solution
Changed all problematic
onClickedhandlers from:To proper toggle logic:
Components Fixed
This ensures consistent toggle behavior across all menu buttons in the application. Users can now properly open and close menus by clicking the same button.
Fixes #2818.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.