-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[ui] Keep projects in recent list even if there is a load error #2850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2850 +/- ##
========================================
Coverage 80.76% 80.76%
========================================
Files 56 56
Lines 7751 7751
========================================
Hits 6260 6260
Misses 1491 1491 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Wouldn't it be better to distinguish the case where the load error occurs because the file does not exist anymore (in which case we have no reason to keep it in the list at all) from the case where there's a "real" loading error (in which case it does make sense to keep the project in the list)? |
Yes, you're right! |
f88771b
to
0362a62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please handle the case where the file is missing separately :)
0362a62
to
ac2ce53
Compare
No description provided.