Skip to content

Conversation

fabiencastan
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.76%. Comparing base (480e498) to head (ac2ce53).
⚠️ Report is 4 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2850   +/-   ##
========================================
  Coverage    80.76%   80.76%           
========================================
  Files           56       56           
  Lines         7751     7751           
========================================
  Hits          6260     6260           
  Misses        1491     1491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac
Copy link
Contributor

Wouldn't it be better to distinguish the case where the load error occurs because the file does not exist anymore (in which case we have no reason to keep it in the list at all) from the case where there's a "real" loading error (in which case it does make sense to keep the project in the list)?

@fabiencastan fabiencastan added this to the Meshroom 2026.1.0 milestone Sep 19, 2025
@fabiencastan
Copy link
Member Author

Yes, you're right!

Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle the case where the file is missing separately :)

@Alxiice
Copy link
Contributor

Alxiice commented Oct 17, 2025

So I did the update this way by disabling items

Note

I think this is better because maybe users want to be aware that one of their projects is missing, because it could be due to folder renaming / disk that is unplugged

image On the home page we can still remove the entry : image

@Alxiice Alxiice requested a review from cbentejac October 17, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants