[ui] Remove "Display Lighting Circle" option #2921
Draft
+0
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2921 +/- ##
==========================================
Coverage ? 80.78%
==========================================
Files ? 56
Lines ? 7749
Branches ? 0
==========================================
Hits ? 6260
Misses ? 1489
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cbentejac
force-pushed
the
dev/sphereDetectionWithShapeFile
branch
from
3274d6c to
95d498d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relates to alicevision/AliceVision#2005 and removes the "Display Lighting Circle" option from the 2D Viewer. The manual detection of the sphere as well as its display are now handled directly within the nodes, based on the support of shapes (introduced by #2908).