Skip to content

Conversation

@Alxiice
Copy link
Contributor

@Alxiice Alxiice commented Oct 21, 2025

Move submitters to https://github.com/meshroomHub/mrSubmitters
This PR works with the current master in the repo above

Steps before deploying :

  1. Deploy mrSubmitters (make sure it's available in production etc)
  2. Merge this PR
  3. Add mrSubmitters as requirement to package.py in meshroom

@Alxiice Alxiice self-assigned this Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (cf6e719) to head (51cfd91).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/submitter.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2926      +/-   ##
===========================================
- Coverage    80.88%   80.88%   -0.01%     
===========================================
  Files           59       59              
  Lines         7853     7857       +4     
===========================================
+ Hits          6352     6355       +3     
- Misses        1501     1502       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac force-pushed the dev/remove_submitters branch from 4b47850 to 51cfd91 Compare November 4, 2025 14:10
@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone Nov 4, 2025
@cbentejac cbentejac merged commit 4585522 into develop Nov 4, 2025
4 checks passed
@cbentejac cbentejac deleted the dev/remove_submitters branch November 4, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants