Skip to content

Conversation

@cbentejac
Copy link
Contributor

Description

This PR prevents unexplicit error messages thrown in AttributeError and RuntimeError exceptions when there is an attempt to run a CompatibilityNode, and replaces them with explicit messages that do not throw exceptions.

Attempting to run a CompatibilityNode led to exceptions that were thrown with messages such as "NoneType" object has no attribute "preprocess", which did not explain that the node had no preprocess method because it was a CompatibilityNode.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.85%. Comparing base (574538e) to head (48ff8c4).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/graph.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2932      +/-   ##
===========================================
- Coverage    80.87%   80.85%   -0.02%     
===========================================
  Files           57       57              
  Lines         7796     7799       +3     
===========================================
+ Hits          6305     6306       +1     
- Misses        1491     1493       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants