[UI] Create a new file manager to handle save as new version #2951

Alxiice · 2025-12-09T09:17:26Z

Why this PR ?

Having a way to save as a new version without overriding the current file
Having a more modern save UI standardized through different platforms

I was mainly inspired by Blender save UI :

Description of the content

Create a new file manager :

Left part with standard directories and favourites
Add right part with
- search toolbar
- file list view
- open/save toolbar
the bottom toolbar is the main new addition :
- there's a "+" sign that changes the name of the file to add an index so that we can save a new version
- if the file exists the rectangle is colored in red to have a visual feedback

Next steps

If reviewers are okay with this proposal there's a few changes to add still :

Replace all the file dialogs with this UI by default, test all
Add buttons to go to previous location, create folder
Add button to filter files and filter to ".mg" by default
tests
...

codecov · 2025-12-09T09:18:24Z

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.75%. Comparing base (cca5cc5) to head (44b26e4).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
meshroom/core/graph.py	40.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2951      +/-   ##
===========================================
- Coverage    79.80%   79.75%   -0.05%     
===========================================
  Files           64       64              
  Lines         8674     8684      +10     
===========================================
+ Hits          6922     6926       +4     
- Misses        1752     1758       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot · 2026-01-14T10:15:33Z

meshroom/ui/qml/Dialogs/MrFileDialog.qml

+
+    // Custom title bar
+    // Could be used to add options and menus
+    // For now only the name of the mode (Opn/Save and a close UI button)


There's a typo in this comment. "Opn" should be "Open".

Suggested change

// For now only the name of the mode (Opn/Save and a close UI button)

// For now only the name of the mode (Open/Save and a close UI button)

Copilot · 2026-01-14T10:15:33Z

meshroom/ui/qml/Application.qml

+        // onRejected: {
+        //     console.log("File not saved")
+        // }


This commented-out code should be removed if it's not needed. Keeping commented-out code reduces maintainability.

Suggested change

// onRejected: {

// console.log("File not saved")

// }

Copilot · 2026-01-14T10:15:34Z

meshroom/ui/qml/Dialogs/MrFileDialog.qml

+                                    // Split filename and extension
+                                    var lastDotIndex = filename.lastIndexOf(".")
+                                    var baseName = ""
+                                    var extension = ""
+
+                                    if (lastDotIndex > 0) {
+                                        baseName = filename.substring(0, lastDotIndex)
+                                        extension = filename.substring(lastDotIndex)
+                                    } else {
+                                        baseName = filename
+                                    }


When a file doesn't have an extension (lastDotIndex <= 0), the extension variable remains empty but is still concatenated. While this works correctly, the condition should be lastDotIndex > 0 (which it is), but the comment or logic could be clearer about this edge case. The current implementation is correct but could benefit from a comment explaining the handling of files without extensions.

Copilot · 2026-01-14T10:15:34Z

meshroom/ui/qml/Dialogs/MrFileDialog.qml

+                            }
+
+                            Label {
+                                text: model.fileIsDir ? "" : (model.fileSize / 1024).toFixed(1) + " KB"


The file size is always displayed in KB (kilobytes), which may not be appropriate for very large files. Consider implementing dynamic units (KB, MB, GB) based on file size for better readability. For example, files larger than 1024 KB could be shown in MB.

Copilot · 2026-01-14T10:15:34Z

meshroom/ui/palette.py

+    @Slot(result=bool)
+    def isDarkPalette(self):
+        return QApplication.instance().palette() == self.darkPalette


The isDarkPalette method uses equality comparison (==) to check if the current palette is the dark palette. This comparison may not work as expected since QPalette objects may not be comparable with ==. Consider using a dedicated boolean flag to track which palette is active, or compare specific palette properties instead.

Copilot · 2026-01-14T10:15:34Z

meshroom/ui/qml/Dialogs/MrFileDialog.qml

+                color: Qt.lighter(root.activePalette.base, 1.4)
+
+                function getSelectedPath() {
+                    return folderModel.folder.toString().replace("file://", "") + "/" + filenameField.text


The path concatenation using + "/" + could result in double slashes or incorrect paths if folderModel.folder already ends with a slash or if filenameField.text is empty. Consider using proper path joining utilities or handling edge cases explicitly to ensure correct path construction.

Suggested change

return folderModel.folder.toString().replace("file://", "") + "/" + filenameField.text

var basePath = folderModel.folder.toString().replace("file://", "");

// Remove trailing slash from basePath, if any

if (basePath.length > 1 && basePath[basePath.length - 1] === "/") {

basePath = basePath.slice(0, -1);

}

var fileName = filenameField.text;

if (!fileName) {

return basePath;

}

return basePath + "/" + fileName;

Copilot · 2026-01-14T10:15:35Z

meshroom/ui/qml/Application.qml

+        property string fileToSave: ""
+
+        onFileSelected: (path) => {
+            fileToSave = path.toString().replace("file://", "")
+            // Do something with the file path
+        }
+
+        onAccepted: {
+            if (!validateFilepathForSave(fileToSave, newSaveFileDialog))
+            {
+                return;
+            }
+
+            // Only save a valid file
+            _reconstruction.saveAs("file://" + fileToSave)


The variable 'fileToSave' is declared as a property but its value assignment in the onFileSelected handler appears redundant since the same path is already captured in the 'path' parameter and used in onAccepted. The fileToSave property could be removed and the path parameter from fileSelected could be used directly, or if it serves a specific purpose, that should be documented.

Suggested change

property string fileToSave: ""

onFileSelected: (path) => {

fileToSave = path.toString().replace("file://", "")

// Do something with the file path

}

onAccepted: {

if (!validateFilepathForSave(fileToSave, newSaveFileDialog))

{

return;

}

// Only save a valid file

_reconstruction.saveAs("file://" + fileToSave)

onAccepted: (path) => {

let fileToSave = path.toString().replace("file://", "")

if (!validateFilepathForSave(fileToSave, newSaveFileDialog))

{

return;

}

// Only save a valid file

_reconstruction.saveAs(path.toString())

Copilot · 2026-01-14T10:15:35Z

meshroom/ui/qml/Dialogs/MrFileDialog.qml

+                function getSelectedPath() {
+                    return folderModel.folder.toString().replace("file://", "") + "/" + filenameField.text


Multiple places in this file use .replace("file://", "") to convert URLs to paths. This pattern is repeated throughout (lines 279, 303, 433, 522, 628). Consider creating a utility function to handle this conversion consistently and correctly, which would improve maintainability and reduce code duplication.

Suggested change

function getSelectedPath() {

return folderModel.folder.toString().replace("file://", "") + "/" + filenameField.text

function fileUrlToPath(url) {

return url.toString().replace("file://", "")

}

function getSelectedPath() {

return fileUrlToPath(folderModel.folder) + "/" + filenameField.text

Copilot · 2026-01-14T10:15:35Z

meshroom/ui/qml/Application.qml

                    }
                }
+                Action {
+                    id: newSaveAsAction


The action name "newSaveAsAction" is somewhat ambiguous. The "new" prefix suggests creating something new, but this is actually a "Save As" action that allows saving with version incrementing. Consider renaming to something more descriptive like "saveAsWithVersionAction" or "saveAsNewVersionAction" to better reflect its purpose.

Suggested change

id: newSaveAsAction

id: saveAsNewVersionAction

Copilot · 2026-01-14T10:15:36Z

meshroom/ui/qml/Dialogs/MrFileDialog.qml

+                        onClicked: {
+                            var url = folderModel.folder.toString()
+                            var parentPath = url.substring(0, url.lastIndexOf("/"))
+                            if (parentPath.length > 7) // more than "file://"
+                                folderModel.customFolder = parentPath
+                        }


When the "Go up one level" button is clicked and the parent path length check fails (line 425), the operation silently does nothing. Consider providing user feedback (e.g., disabling the button or showing a tooltip) when at the root directory to indicate why navigation up is not possible.

Alxiice self-assigned this Dec 9, 2025

Alxiice requested a review from cbentejac December 9, 2025 09:17

Alxiice assigned fabiencastan Dec 9, 2025

Alxiice unassigned fabiencastan Dec 9, 2025

Alxiice requested a review from fabiencastan December 9, 2025 09:18

Alxiice force-pushed the dev/save_as_updates branch 2 times, most recently from 4ebff46 to d30cf11 Compare December 12, 2025 14:25

Alxiice added the feature new feature (proposed as PR or issue planned by dev) label Dec 12, 2025

Alxiice added this to the Meshroom 2026.1.0 milestone Dec 12, 2025

cbentejac requested a review from Copilot January 14, 2026 10:03

Copilot started reviewing on behalf of cbentejac January 14, 2026 10:04 View session

Alxiice force-pushed the dev/save_as_updates branch from d30cf11 to 5aba40d Compare January 14, 2026 10:06

Copilot AI reviewed Jan 14, 2026

View reviewed changes

Alxiice force-pushed the dev/save_as_updates branch 2 times, most recently from a1d8fd0 to 7cf7035 Compare January 19, 2026 09:15

Alxiice added 2 commits January 21, 2026 12:08

[ui] Add new saveAs window

e897bdc

[ui] file dialog : fix light palette issues

44b26e4

Alxiice force-pushed the dev/save_as_updates branch from 7cf7035 to 44b26e4 Compare January 21, 2026 11:09

Alxiice marked this pull request as draft January 21, 2026 11:09

	// For now only the name of the mode (Opn/Save and a close UI button)
	// For now only the name of the mode (Open/Save and a close UI button)

-                    return folderModel.folder.toString().replace("file://", "") + "/" + filenameField.text
+                    var basePath = folderModel.folder.toString().replace("file://", "");
+                    // Remove trailing slash from basePath, if any
+                    if (basePath.length > 1 && basePath[basePath.length - 1] === "/") {
+                        basePath = basePath.slice(0, -1);
+                    }
+                    var fileName = filenameField.text;
+                    if (!fileName) {
+                        return basePath;
+                    }
+                    return basePath + "/" + fileName;

		function getSelectedPath() {
		return folderModel.folder.toString().replace("file://", "") + "/" + filenameField.text

Uh oh!

[UI] Create a new file manager to handle save as new version #2951

Are you sure you want to change the base?

[UI] Create a new file manager to handle save as new version #2951

Uh oh!

Conversation

Alxiice commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why this PR ?

Description of the content

Next steps

Uh oh!

codecov bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alxiice commented Dec 9, 2025 •

edited

Loading

codecov bot commented Dec 9, 2025 •

edited

Loading