-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[ui/core] Add a menu to increment file version #2980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2980 +/- ##
===========================================
+ Coverage 79.61% 79.74% +0.12%
===========================================
Files 64 64
Lines 8595 8648 +53
===========================================
+ Hits 6843 6896 +53
Misses 1752 1752 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4ad48f2 to
345a3aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a "Save New Version" feature that automatically increments the version number in the filename when saving. The implementation adds a new menu item with a keyboard shortcut (Ctrl+Alt+S) that generates the next available version number (e.g., scene.mg → scene1.mg → scene2.mg).
Changes:
- Added UI action in the File menu for "Save New Version" with Ctrl+Alt+S shortcut
- Implemented version incrementing logic using regex pattern matching
- Integrated the feature through UI and core graph layers
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| meshroom/ui/qml/Application.qml | Adds "Save New Version" action to File menu with keyboard shortcut and proper enable conditions |
| meshroom/ui/graph.py | Adds UI layer wrapper for saveAsNewVersion that delegates to core and manages undo stack |
| meshroom/core/graph.py | Implements core logic for version path generation and saving to new version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
876a878 to
d1f655f
Compare
d1f655f to
911f199
Compare
Description of the PR
Increments the version of the file and save
Note
Here are the rules to increment the version :
Ctrl+Alt+SReview requested
'^(.+?)(\d+)$'that is supposed to catch the name (sceneN.mg)