Skip to content

Conversation

@Alxiice
Copy link
Contributor

@Alxiice Alxiice commented Jan 19, 2026

Description of the PR

Increments the version of the file and save

Note

Here are the rules to increment the version :

  • scene.mg -> scene1.mg
  • scene1.mg -> scene2.mg
  • scene1.mg and scene2.mg exists -> scene3.
  • Add a "Save new version" button in the file menu
  • The shortcut is Ctrl+Alt+S
image

Review requested

  • You can try to break the regex '^(.+?)(\d+)$' that is supposed to catch the name (sceneN.mg)

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.74%. Comparing base (da30eaf) to head (911f199).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2980      +/-   ##
===========================================
+ Coverage    79.61%   79.74%   +0.12%     
===========================================
  Files           64       64              
  Lines         8595     8648      +53     
===========================================
+ Hits          6843     6896      +53     
  Misses        1752     1752              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a "Save New Version" feature that automatically increments the version number in the filename when saving. The implementation adds a new menu item with a keyboard shortcut (Ctrl+Alt+S) that generates the next available version number (e.g., scene.mg → scene1.mg → scene2.mg).

Changes:

  • Added UI action in the File menu for "Save New Version" with Ctrl+Alt+S shortcut
  • Implemented version incrementing logic using regex pattern matching
  • Integrated the feature through UI and core graph layers

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
meshroom/ui/qml/Application.qml Adds "Save New Version" action to File menu with keyboard shortcut and proper enable conditions
meshroom/ui/graph.py Adds UI layer wrapper for saveAsNewVersion that delegates to core and manages undo stack
meshroom/core/graph.py Implements core logic for version path generation and saving to new version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Alxiice Alxiice force-pushed the dev/save_increment_version branch from 876a878 to d1f655f Compare January 19, 2026 16:50
@Alxiice Alxiice force-pushed the dev/save_increment_version branch from d1f655f to 911f199 Compare January 19, 2026 16:58
@cbentejac cbentejac merged commit c939290 into develop Jan 20, 2026
4 checks passed
@cbentejac cbentejac deleted the dev/save_increment_version branch January 20, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature (proposed as PR or issue planned by dev)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants