Skip to content

[ui] NodeActions : fix position on swiching status #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alxiice wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[ui] NodeActions : fix position on swiching status #2981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9237eff
[ui] NodeActions : fix position on computing/none status
Alxiice Jan 21, 2026
55bc4ac
[ui] NodeActions: update position when nodes are moved
Alxiice Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions meshroom/ui/qml/Controls/NodeActions.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,20 @@ Item {
}
}
Copy link
Contributor

@cbentejac cbentejac Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the if (!selectedNodeDelegate || !draggable) return, I would add:


if (width == 0 && height == 0) {
    actionItemsRow.visible = true
    return
} else if (width == 0 || height == 0) {
    actionItemsRow.visible = false
    return
}
actionItemsRow.visible = true

if (!selectedNodeDelegate || !draggable) return
...


onHeightChanged: {
Qt.callLater(actionHeader.updatePosition)
Copy link
Contributor

@cbentejac cbentejac Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Qt.callLater(actionHeader.updatePosition)
actionHeader.updatePosition()

}

onWidthChanged: {
updatePosition()
Qt.callLater(actionHeader.updatePosition)
Copy link
Contributor

@cbentejac cbentejac Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Qt.callLater(actionHeader.updatePosition)
actionHeader.updatePosition()

}

// Update position when the user moves on the graph
Connections {
target: root.draggable
function onXChanged() { actionHeader.updatePosition() }
function onYChanged() { actionHeader.updatePosition() }
function onScaleChanged() { actionHeader.updatePosition() }
function onXChanged() { Qt.callLater(actionHeader.updatePosition) }
function onYChanged() { Qt.callLater(actionHeader.updatePosition) }
function onScaleChanged() { Qt.callLater(actionHeader.updatePosition) }
}

// Update position when nodes are moved
Expand Down
4 changes: 3 additions & 1 deletion meshroom/ui/qml/GraphEditor/ChunksListView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ ColumnLayout {

onChunksChanged: {
// When the list changes, ensure the current index is in the new range
if (currentIndex >= chunks.count)
if (!chunks)
currentIndex = -1
else if (chunks && currentIndex >= chunks.count)
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition chunks && is redundant here since it's already in the else-if branch that only executes when chunks is truthy (the if statement on line 21 handles the null/falsy case).

Suggested change
else if (chunks && currentIndex >= chunks.count)
else if (currentIndex >= chunks.count)

Copilot uses AI. Check for mistakes.
currentIndex = chunks.count-1
}

Expand Down
Loading