Add output for intermediate images during Gaussian pyramid building #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simogasp
approved these changes
Oct 14, 2025
| POP_CUDA_FATAL_TEST(err, "cudaMemcpy3D failed: "); | ||
|
|
||
| for( int l = 0; l<_levels; l++ ) { | ||
| Plane2D_float p(width, height, &array[l*width*height], width * sizeof(float)); |
There was a problem hiding this comment.
Just minor, canp be const?
Normally write_plane2Dunscaled should just write it to a file without modifying it. (sorry cannot check atm...)
There was a problem hiding this comment.
Conceptually, it can definitely be const. I’ll try and see if the underlying plane code needs updates for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the creation of the Gaussian pyramid, PopSift can write a sequence of PGM images to a folder named dir-octave for debugging if its config parameter logMode is set to All. While working on a new branch, the need for additional output appeared. It keeps the intermediate images that are created in each horizontal sweeps (but before the each vertical) of pyramid building as well. This new output is written to a folder called dir-interm.
Also three tiny images for debugging have been added in the testImages folder.
Features list
Implementation remarks
The new code is identical to the code that writes the Gaussian pyramid to disk, just that it writes the cudaArray _intm of each Octave object instead of the cudaArray _data.