Optional refresh token in implicit grant #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution proposal for issues: aliev#98. This commit includes additional logic to make the generation of refresh tokens optional in implicit grant flows so that this package becomes strictly compliant with the OAuth 2.0 specification in section 4.2. To see further information, please refer to issue aliev#98. To not break backward compatibility, this new option has been included as an new optional setting flag, `ISSUE_REFRESH_TOKEN_IMPLICIT_GRANT`, that when set to `False`, it deactivates the refresh token generation in implicit flows.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 94.49% 94.55% +0.05%
==========================================
Files 17 17
Lines 763 771 +8
Branches 112 114 +2
==========================================
+ Hits 721 729 +8
Misses 33 33
Partials 9 9 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 30, 2024
aliev
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution proposal for issues: #98.
This commit includes additional logic to make the generation of refresh tokens optional in implicit grant flows so that this package becomes strictly compliant with the OAuth 2.0 specification in section 4.2. To see further information, please refer to issue #98.
To not break backward compatibility, this new option has been included as an new optional setting flag,
ISSUE_REFRESH_TOKEN_IMPLICIT_GRANT, that when set toFalse, it deactivates the refresh token generation in implicit flows.