feat: refactor storage methods to use keyword-only arguments for clarity #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the use of `Unpack` and `TypedDict` in favor of named parameters, as these introduce additional "hacks" to support older Python versions, making the code more complex. Discussion thread: https://github.com/aliev/aioauth/pull/106#issuecomment-2484151019# Please enter the commit message for your changes. Lines starting
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
|
Fair. It was a good idea in theory. I take responsibility for being the one to recommend it initially. My bad lol. |
That was still a good recommendation! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
UnpackandTypedDictin favor of named parameters, as these introduce additional "hacks" to support older Python versions, making the code more complex.Discussion thread: https://github.com/aliev/aioauth/pull/106#issuecomment-2484151019# Please enter the commit message for your changes. Lines starting