-
-
Notifications
You must be signed in to change notification settings - Fork 77
Update gridify-client to support modern builders #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 💐👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not JS expert but I was wondering isn't it better to change the exports to .
?
".": {
"require": "./dist/index.cjs.js",
"import": "./dist/index.esm.js",
"browser": "./dist/index.umd.js",
"types": "./dist/index.d.ts"
}
If I'm not wrong this way native ESM consumers won’t hit “Export not defined” errors.
That makes sense, I have updated the PR |
Thanks for accepting my PR @alirezanet! Any chance you could run the pipeline to deploy to NPM? |
Hi @frasermclean, |
It is released https://github.com/alirezanet/Gridify/releases/tag/c-v2.1.0 |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #271
Type of change
Checklist