Skip to content

Update gridify-client to support modern builders #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

frasermclean
Copy link
Contributor

@frasermclean frasermclean commented May 21, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #271

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Copy link

what-the-diff bot commented May 21, 2025

PR Summary

  • Version Update
    The version of the software package has been updated from 2.0.2 to 2.0.3. This could result in better stability or additional features.

  • Additional Entry Points
    We've added an exports field to allow different entry points for various uses such as require, import, browser, and types. This makes our software more versatile depending on where and how you want to use it.

  • Reinclusion of ts-jest Dependency
    We've reintroduced the dependency ts-jest to our project, using version ^29.1.1. This might imply that we are looking to perform testing or transformations involving TypeScript in our software, allowing us to ensure its reliability.

Copy link
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💐👌

Copy link
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not JS expert but I was wondering isn't it better to change the exports to . ?

".": {
  "require": "./dist/index.cjs.js",
  "import":  "./dist/index.esm.js",
  "browser": "./dist/index.umd.js",
  "types":   "./dist/index.d.ts"
}

If I'm not wrong this way native ESM consumers won’t hit “Export not defined” errors.

@frasermclean
Copy link
Contributor Author

That makes sense, I have updated the PR

@alirezanet alirezanet merged commit 0eba4c2 into alirezanet:master May 22, 2025
1 check passed
@frasermclean
Copy link
Contributor Author

frasermclean commented May 26, 2025

Thanks for accepting my PR @alirezanet! Any chance you could run the pipeline to deploy to NPM?

@alirezanet
Copy link
Owner

Thanks for accepting my PR @alirezanet! Any chance you could run the pipeline to deploy to NPM?

Hi @frasermclean,
After this PR, I’ll release a new version. Feel free to review the PR if you’d like to help speed up the process. I’d really appreciate a second pair of eyes—especially when it comes to TypeScript :)

@alirezanet alirezanet added the gridify-client Issues related to the TypeScript client label May 26, 2025
@alirezanet
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gridify-client Issues related to the TypeScript client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gridify-client: reported as not being ESM
2 participants