Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: refine cmake target name for better integration #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

royguo
Copy link

@royguo royguo commented Sep 6, 2021

The previous target cpp-sdk is quite confusing for higher-level applications. We should rename the target name with
oss-cpp-sdk and thus all related CMake scrips should be also changed.

Signed-off-by: Roy Guo [email protected]

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

The previous target name is `cpp-sdk` which is quite confusing for
higher level applications. We should rename the target name with
`oss-cpp-sdk` and thus all related CMake scrips should be also changed.

Signed-off-by: Roy Guo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants