FIX: Show Documentation URL if KB v1.2.25+ Installed

- fixes #16
aljawaid · Aug 18, 2023 · 200be52 · 200be52
1 parent c97779a
commit 200be52
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/Helper/ApplicationBrandingHelper.php b/Helper/ApplicationBrandingHelper.php
@@ -13,23 +13,17 @@
 class ApplicationBrandingHelper extends Base
 {
     /**
-     * Get Help Docs
+     * Get Help Docs - Helper to generate a link to the documentation
      *
      * @see     about.php
+     * @see     UrlHelper.php
      * @access  public
      * @return  string
      */
-    public function getDocs($label, $file)
+    public function getDocs($label, $file = '')
     {
-        $version = 'latest';
+        $url = sprintf(DOCUMENTATION_URL_PATTERN, $file);
 
-        if (substr(APP_VERSION, 0, 1) === 'v') {
-            $version = substr(APP_VERSION, 1);
-        } elseif (ctype_digit(substr(APP_VERSION, 0, 1))) {
-            $version = APP_VERSION;
-        }
-
-        $url = sprintf(DOCUMENTATION_URL_PATTERN, $version, $file);
         return sprintf('
             <a href="%s" class="channels-link" title="' . t('Opens in a new window') . '" rel="noopener noreferrer" target="_blank">
                 <div class="icon-wrapper wrapper-docs">

diff --git a/Template/config/about.php b/Template/config/about.php
@@ -325,9 +325,11 @@
                     <span class="channels-name"><?= t('Website') ?></span>
                 </a>
             </div>
-            <div class="channels-wrapper">
-                <?= $this->helper->applicationBrandingHelper->getDocs(t('Documentation'), 'index') ?>
-            </div>
+            <?php if (APP_VERSION > '1.2.25'): ?>
+                <div class="channels-wrapper">
+                    <?= $this->helper->applicationBrandingHelper->getDocs(t('Documentation')) ?>
+                </div>
+            <?php endif ?>
             <div class="channels-wrapper">
                 <a href="https://kanboard.org/plugins.html" class="channels-link" title="<?= t('Opens in a new window') ?>" rel="noopener noreferrer" target="_blank">
                     <div class="icon-wrapper wrapper-plugins">