Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix synth_pref functions #511

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Fix synth_pref functions #511

merged 3 commits into from
Jan 13, 2025

Conversation

ljvmiranda921
Copy link
Member

Reference #506

  • Add missing functions 😓

@ljvmiranda921 ljvmiranda921 marked this pull request as draft January 13, 2025 18:04
@ljvmiranda921 ljvmiranda921 mentioned this pull request Jan 13, 2025
Open
@ljvmiranda921 ljvmiranda921 marked this pull request as ready for review January 13, 2025 18:24
natolambert
natolambert approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@natolambert natolambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks as expected! Do we need the added gitignore (not a big deal).

@ljvmiranda921
Copy link
Member Author

Nice! I moved it to the main .gitignore. Will merge once checks are good!

@ljvmiranda921 ljvmiranda921 merged commit 45e0bde into main Jan 13, 2025
3 checks passed
@ljvmiranda921 ljvmiranda921 deleted the cleanup-fixes branch January 13, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natolambert natolambert natolambert approved these changes

@vwxyzjn vwxyzjn Awaiting requested review from vwxyzjn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljvmiranda921 @natolambert