Address issue where a small number of Sentinel-2 scenes in GCP bucket are missing some bands #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favyen2
changed the title
Hgherzog
reviewed
Dec 19, 2024
|
thanks, made these updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we ignored the error during ingestion. Then we changed it so the error remains. Neither is perfect since this means either the job fails or some items failed to ingest; it would be better to avoid those scenes during prepare (get_items) so that we can read other windows instead (if possible).
This PR implements that, so in get_items we only match with scenes that have all the bands intact in the bucket.
Note this PR depends on #104.