Add data source for the AWS s3://sentinel-cogs bucket maintained by Element 84. #399
+858
−272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lement 84. The data source is very similar to Planetary Computer for get_items implementation, so I created an abstract StacSource to handle cases where basically the get_items is just served from a STAC API. I also implemented a StacClient to replace our usage of pystac_client in cases where we are just calling the search endpoint only; the client only supports that one endpoint, but doesn't have the caching issues since the only thing it does beyond making a request is handle pagination in the response.
yawenzzzz
approved these changes
Jan 13, 2026
Collaborator
yawenzzzz
left a comment
yawenzzzz
left a comment
There was a problem hiding this comment.
LGTM! just a few minor things to fix.
| return SourceItem.deserialize(json.load(f)) | ||
|
|
||
| # No cache or not in cache, so we need to make the STAC request. | ||
| logger.debug("Getting STAC item {name}") |
| "nir": ["B08"], | ||
| "nir09": ["B09"], | ||
| "swir16": ["B11"], | ||
| "swin22": ["B12"], |
| whether there is a raster in the store matching the source, item, and | ||
| bands. | ||
| """ | ||
| # Always ready since we wrap accesses to Planetary Computer. |
Collaborator
There was a problem hiding this comment.
remove "Planetary Computer"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data source is very similar to Planetary Computer for get_items implementation, so I created an abstract StacSource to handle cases where basically the get_items is just served from a STAC API. I also implemented a StacClient to replace our usage of pystac_client in cases where we are just calling the search endpoint only; the client only supports that one endpoint, but doesn't have the caching issues since the only thing it does beyond making a request is handle pagination in the response.
Also it seems the
aws_open_data.Sentinel2bucket is now free so I updated it to use anonymous access for that. That one has a STAC API so in theory we could greatly simplify get_items implementation by calling that API but I left it otherwise as is for now.