Ensure that all terms match the Ad Layer #70
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbenk
approved these changes
Feb 5, 2018
| if ( has_term( $terms, $taxonomy ) ) { | ||
| $taxonomy_match = true; | ||
| } else { | ||
| $taxonomy_match = false; |
There was a problem hiding this comment.
This appears to be a breaking change since themes might be relying on Ad Layers to match for only a single taxonomy. The code is sound, but I just wanted to mention the concern for backwards compatibilty. Maybe an Ad Layers expert can weigh in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all of the Ad Layer's terms are matched. Previously, it would let any match validate the layer for use. This doesn't work when we want to have more granular control over the Ad Layer (multiple taxonomies requiring multiple terms to be matched).