Merge pull request #316 from alleyinteractive/remove-author-dropdown-…

…filter

Allow filtering of post types to remove author dropdown

byline-manager.php

@@ -7,7 +7,7 @@
  * Author URI:      https://alley.com
  * Text Domain:     byline-manager
  * Domain Path:     /languages
- * Version:         0.2.8
+ * Version:         0.3.0
  * Requires WP:     5.9
  * Requires PHP:    8.0
  * Tested up to:    6.4

inc/admin-ui.php

@@ -287,3 +287,23 @@ function render_posts_column( $column, $post_id ): void {
 	}
 }
 add_action( 'manage_profile_posts_custom_column', __NAMESPACE__ . '\render_posts_column', 10, 2 );
+
+/**
+ * Remove the author support from post types.
+ * This is done to prevent the author dropdown from being displayed in the post editor.
+ */
+function remove_author_support() {
+	/**
+	 * Filter the list of post types that should not have author support.
+	 * Defaults to all post types that support Byline Manager.
+	 *
+	 * @param string[] $post_types Post types with author support removed.
+	 */
+	$post_types = apply_filters( 'byline_manager_remove_author_support', Utils::get_supported_post_types() );
+
+	// Remove author support from the provided post types.
+	foreach ( $post_types as $post_type ) {
+		remove_post_type_support( $post_type, 'author' );
+	}
+}
+add_action( 'admin_init', __NAMESPACE__ . '\remove_author_support' );

inc/class-utils.php

@@ -26,7 +26,10 @@ class Utils {
 	 * @return string[] Post types with author support.
 	 */
 	public static function get_supported_post_types(): array {
-		$post_types = get_post_types_by_support( 'author' );
+		static $post_types;
+		if ( ! isset( $post_types ) ) {
+			$post_types = get_post_types_by_support( 'author' );
+		}
 
 		/**
 		 * Filter the list of supported post types. Defaults to all post types

tests/feature/test-profile-byline-sync.php

@@ -52,19 +52,9 @@ public function test_byline_relationships() {
 			]
 		);
 
-		$post_type_with_author = 'test-with-author';
-		register_post_type(
-			$post_type_with_author,
-			[
-				'public'   => true,
-				'supports' => [ 'title', 'editor', 'author' ],
-			]
-		);
-
 		unregister_taxonomy( BYLINE_TAXONOMY );
 		register_byline();
 
 		$this->assertFalse( is_object_in_taxonomy( $post_type_no_author, BYLINE_TAXONOMY ) );
-		$this->assertTrue( is_object_in_taxonomy( $post_type_with_author, BYLINE_TAXONOMY ) );
 	}
 }