[1.12] Work on PHPStan level 7

phpstan.neon

@@ -1,9 +1,6 @@
-includes:
-	- phpstan-baseline.neon
-
 parameters:
 	# Goal of max.
-	level: 6
+	level: 7
 
 	paths:
 		- src/mantle
@@ -52,14 +49,22 @@ parameters:
 		- "#interface ArrayAccess but does not specify#"
 		- "#ReflectionClass does not specify its types#"
 		- "#ReflectionAttribute does not specify its types#"
-		- "#ReflectionAttribute but does not specify its types#"
 		- "#@return is not subtype of template type TKey#"
 		- "#WP_REST_Request does not specify its types#"
 		- "#WP_REST_Request but does not specify its types#"
+		- "#query of method wpdb::prepare#"
 		-
 			identifier: method.childReturnType
 			paths:
 				- src/mantle/http-client/class-pooled-pending-request.php
+		-
+			identifier: argument.type
+			paths:
+				- src/mantle/support/class-collection.php
+		-
+			identifier: return.type
+			paths:
+				- src/mantle/support/class-collection.php
 
 	scanFiles:
 		- %rootDir%/../../php-stubs/wp-cli-stubs/wp-cli-stubs.php
@@ -69,13 +74,19 @@ parameters:
 
 	excludePaths:
 		- src/mantle/blocks
+		- src/mantle/container/class-bound-method.php
 		- src/mantle/database/factory
 		- src/mantle/framework/console/class-hook-usage-command.php
+		- src/mantle/framework/console/generators
 		- src/mantle/query-monitor
 		- src/mantle/queue/providers/wordpress/admin/class-queue-jobs-table.php
 		- src/mantle/queue/providers/wordpress/admin/class-service-provider.php
 		- src/mantle/support/interface-enumerable.php
+		- src/mantle/support/traits/trait-conditionable.php
 		- src/mantle/testing/class-mock-action.php
 		- src/mantle/testing/install-wordpress.php
 		- src/mantle/testing/preload.php
 		- src/mantle/testing/wordpress-bootstrap.php
+
+		# Files that need to be fixed and re-added.
+		- src/mantle/queue/class-queue-fake.php

src/mantle/application/concerns/trait-manages-service-providers.php

@@ -63,7 +63,7 @@ public function register_configured_providers(): void {
 			$providers = $providers->filter(
 				fn ( string $provider ) => in_array(
 					Isolated_Service_Provider::class,
-					class_implements( $provider ),
+					class_implements( $provider ) ?: [],
 					true,
 				)
 			);

src/mantle/assets/autoload.php

@@ -28,7 +28,13 @@ function asset(): Asset_Manager {
 	/**
 	 * Retrieve an instance of the Asset Loader OR the URL for a given asset.
 	 *
+	 * @template TPath of string|null
+	 *
+	 * @param string|null $path Optional. The asset path to retrieve the URL for. If null, returns the Asset Loader instance.
 	 * @return \Mantle\Assets\Asset_Loader|string|null Returns the asset loader instance or the URL if a path is provided.
+	 *
+	 * @phpstan-param TPath $path
+	 * @phpstan-return (TPath is null ? \Mantle\Assets\Asset_Loader : string|null)
 	 */
 	function asset_loader( ?string $path = null ): Asset_Loader|string|null {
 		if ( $path ) {

src/mantle/cache/class-repository.php

@@ -7,6 +7,8 @@
  * phpcs:disable WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
  */
 
+declare(strict_types=1);
+
 namespace Mantle\Cache;
 
 use Closure;
@@ -54,19 +56,19 @@ abstract public function flexible( string $key, int|\DateInterval|\DateTimeInter
 	/**
 	 * Set a cache item.
 	 *
-	 * @param string                 $key Cache key.
-	 * @param mixed                  $value Item value.
-	 * @param null|int|\DateInterval $ttl TTL.
+	 * @param string                                    $key Cache key.
+	 * @param mixed                                     $value Item value.
+	 * @param int|\DateInterval|\DateTimeInterface|null $ttl TTL.
 	 */
-	abstract public function set( string $key, mixed $value, int|\DateInterval|null $ttl = null ): bool;
+	abstract public function set( string $key, mixed $value, int|\DateInterval|\DateTimeInterface|null $ttl = null ): bool;
 
 	/**
 	 * Set multiple keys.
 	 *
-	 * @param iterable<string, mixed> $values Key value pair of values to set.
-	 * @param null|int|\DateInterval  $ttl Cache TTL.
+	 * @param iterable<string, mixed>                   $values Key value pair of values to set.
+	 * @param int|\DateInterval|\DateTimeInterface|null $ttl Cache TTL.
 	 */
-	abstract public function set_multiple( iterable $values, null|int|\DateInterval $ttl = null ): bool;
+	abstract public function set_multiple( iterable $values, int|\DateInterval|\DateTimeInterface|null $ttl = null ): bool;
 
 	/**
 	 * Delete a cache key.

src/mantle/cache/class-wordpress-cache-repository.php

@@ -5,6 +5,8 @@
  * @package Mantle
  */
 
+declare(strict_types=1);
+
 namespace Mantle\Cache;
 
 use Mantle\Contracts\Application;
@@ -46,7 +48,7 @@ public function get( string $key, mixed $default = null ): mixed {
 	 * @return iterable<string, mixed>
 	 */
 	public function get_multiple( iterable $keys, mixed $default = null ): iterable {
-		return \wp_cache_get_multiple( $keys, $this->prefix );
+		return \wp_cache_get_multiple( is_array( $keys ) ? $keys : iterator_to_array( $keys ), $this->prefix );
 	}
 
 	/**
@@ -135,7 +137,7 @@ public function set( string $key, mixed $value, int|\DateInterval|\DateTimeInter
 	 * @param null|int|\DateInterval|\DateTimeInterface $ttl Cache TTL.
 	 */
 	public function set_multiple( iterable $values, null|int|\DateInterval|\DateTimeInterface $ttl = null ): bool {
-		$result = \wp_cache_set_multiple( $values, $this->prefix, $this->normalize_ttl( $ttl ) ); // phpcs:ignore WordPressVIPMinimum.Performance.LowExpiryCacheTime.CacheTimeUndetermined
+		$result = \wp_cache_set_multiple( is_array( $values ) ? $values : iterator_to_array( $values ), $this->prefix, $this->normalize_ttl( $ttl ) ); // phpcs:ignore WordPressVIPMinimum.Performance.LowExpiryCacheTime.CacheTimeUndetermined
 
 		return ! in_array( false, $result, true );
 	}
@@ -175,7 +177,7 @@ public function delete( string $key ): bool {
 	 * @param iterable<string> $keys Cache keys.
 	 */
 	public function delete_multiple( iterable $keys ): bool {
-		$result = \wp_cache_delete_multiple( $keys, $this->prefix );
+		$result = \wp_cache_delete_multiple( is_array( $keys ) ? $keys : iterator_to_array( $keys ), $this->prefix );
 
 		return ! in_array( false, $result, true );
 	}