Improve I18N Issues (Based on version 7) #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fully localized this plugin to zh_TW and found several I18N issues. 1. This plugin’s `Requires at least (3.8)` is below 4.6, so a `load_plugin_textdomain` is needed. Please make sure you load it at a certain point in your plugin. Please refer to [this official article](https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain). 2. This plugin’s `Requires at least` is below 4.6, so you need to set a Text Domain in `options-importer.php`, and it needs to be `options-importer` to internationalize your plugin correctly! Please refer to [this official article](https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains). 3. Please correct the text domain from `wp-options-importer` to `options-importer`. 4. Please add the correct text domain `options-importer` for some UI strings without the text domain. 5. Please look at this PR and see what I changed. So that you know, I did NOT add the load_plugin_textdomain function; you must add it yourself. 6. This plugin’s [GlotPress project](https://translate.wordpress.org/projects/wp-plugins/options-importer/) should be completed after fixing the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fully localized this plugin to zh_TW and found several I18N issues.
Requires at least (3.8)is below 4.6, so aload_plugin_textdomainis needed. Please make sure you load it at a certain point in your plugin. Please refer to this official article.Requires at leastis below 4.6, so you need to set a Text Domain inoptions-importer.php, and it needs to beoptions-importerto internationalize your plugin correctly! Please refer to this official article.wp-options-importertooptions-importer.options-importerfor some UI strings without the text domain.