Skip to content

Conversation

@anubisthejackle
Copy link
Contributor

@anubisthejackle anubisthejackle commented Oct 15, 2024

Summary

As titled. Fixes #70

Notes for reviewers

None.

Other Information

  • I updated the README.md file for any new/updated features.
  • I updated the CHANGELOG.md file for any new/updated features.

Changelog entries

Added

  • Refresh mechanism for persisted pages to ensure nonce validation.

Changed

Deprecated

Removed

  • Unnecessary nonce validation check that failed for empty values.

Fixed

Security

@anubisthejackle anubisthejackle marked this pull request as ready for review October 15, 2024 18:27
@anubisthejackle anubisthejackle requested a review from a team as a code owner October 15, 2024 18:27
Copy link
Contributor

@renatonascalves renatonascalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

public static function action__add_meta_refresh(): void {
printf( '<meta http-equiv="refresh" content="%d">', esc_attr( (string) self::NONCE_TIMEOUT ) );
?>
<script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be good to add a code comment so that it points back to this feature?

@anubisthejackle anubisthejackle merged commit a16665f into main Oct 17, 2024
6 checks passed
@anubisthejackle anubisthejackle deleted the fix/issue-70/login-nonce-fails-bfcache-cached-pages branch October 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Login Nonce fails for pages "cached" by bfcache

4 participants