Issue-48: Disable_Comments should disable its blocks
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llflannery
added
gutenberg
kevinfodness
requested changes
Feb 3, 2025
Member
kevinfodness
left a comment
kevinfodness
left a comment
There was a problem hiding this comment.
Left two comments about making the JavaScript more defensive depending on where it loads in the admin. There's also a failing test (looks to be a PHP linter, but I'm not clear on where it's failing). Let me know when my requested changes are made and when the tests are passing and I'll give it another look and approve. Also let me know if you need help with getting the PHP linter to pass. Thanks for taking this one on!
Co-authored-by: Kevin Fodness <[email protected]>
dlh01
reviewed
Feb 3, 2025
kevinfodness
approved these changes
Feb 5, 2025
Member
kevinfodness
left a comment
kevinfodness
left a comment
There was a problem hiding this comment.
One stylistic thing to adjust before merge, otherwise 🍣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As titled. Fixes #48
Notes for reviewers
None.
Other Information
README.mdfile for any new/updated features.CHANGELOG.mdfile for any new/updated features.Changelog entries
Added
Changed
Now the only Comments-related block is Comments Widget (on NYP)
Deprecated
Removed
Four comments-related blocks
unregisterBlockType('core/post-comments-form');unregisterBlockType('core/comments');unregisterBlockType('core/comments-query-loop');unregisterBlockType('core/latest-comments');Fixed
Security