Issue-44: PHP Warning: Undefined array key \"linkDestination\" in class-image.php
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a PHP warning caused by accessing an undefined array key linkDestination in the Image block class by adding an ! empty() check before accessing the key.
Key Changes:
- Added a conditional check using
! empty()to verifylinkDestinationexists before comparing its value to'none' - Reformatted the conditional logic across multiple lines for improved readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nikkifurls
force-pushed
the
fix/issue-44/php-warning-linkdestination-check
branch
from
e902957 to
adc1375
Compare
nikkifurls
commented
Nov 17, 2025
Comment on lines
+73
to
+74
| - name: Install Subversion | ||
| run: sudo apt-get update && sudo apt-get install -y subversion |
Contributor
Author
There was a problem hiding this comment.
The PHPUnit step was failing with svn: command not found
srtfisher
approved these changes
Nov 18, 2025
nikkifurls
deleted the
fix/issue-44/php-warning-linkdestination-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #44
As titled.
Notes for reviewers
None.
Changelog entries
! empty()check to prevent PHP warning: Undefined array key "linkDestination" inclass-image.php.Issue(s)
#44