Add experimental support for matching blocks with XPath #18
Conversation
|
|
||
| Although it's possible to use XPath queries in conjunction with other `match_blocks()` arguments, the results with some arguments might be unexpected. | ||
|
|
||
| Typically, `match_blocks()` returns the blocks that match all the arguments. But when the `__experimental_xpath` argument is used, the set of source blocks will be first reduced to the blocks that match the XPath query, and then the remaining arguments will be applied. |
There was a problem hiding this comment.
Might it be worth hinting this behavior in the name of the argument? Something like __experimental_xpath_block_pre_filter?
There was a problem hiding this comment.
I hadn't considered this approach, so I gave it some thought, but I decided to keep the existing name primarily because I don't want the name to become inaccurate in a future iteration.
It's not impossible to make the XPath argument work the same way as the other arguments, but it takes a bigger refactor than I feel like doing right now.
Also, practically speaking, I haven't yet imagined a situation where someone would use XPath in conjunction with the other affected arguments anyway. XPath can pretty much do everything the other arguments can, plus more.
Summary
As titled.
Notes for reviewers
Depends on alleyinteractive/wp-type-extensions#29.