Editable attributes #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Begin the implementation of attr('source', 'setter') and
attr('relative', 'setter'). Since these are probably the easiest to
implement for now.
setter implies some sort of function
Contributor
Author
|
As a note, someone has implemented parameter modifications on my branch and whilst there a few things I'm nitpicking on with the code (indentation is all changed, the name of the string conversion method) it does from a quick glance look good. Is there any chance we can also look at that too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is not perfect, but is a basic implementation of using attr with function overloading ... it is backwards compatible with the current implementation.
attr('foo') does whatever it does currently, however attr('foo', 'bar') sets foo to bar and bubbles up any building dependencies of foo and returns whatever bits need to be set.
I've added a basic test suite which i used to build the functionality, but, if there are any edge cases that you think need to be addressed, just add them to the suite and I'll try and fix.