feat: add a method for an in-memory comparison between a Filter and Log #2179
+209
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
startup-dreamer
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
startup-dreamer
changed the title
yash-atreya
requested changes
Mar 18, 2025
|
Please review @yash-atreya, I think tests can be improved (but let me know). |
|
Without certifying the accuracy of the function, this is the exact intent I had! Thank you. |
mattsse
reviewed
Mar 19, 2025
DaniPopes
reviewed
Apr 6, 2025
| /// | ||
| /// Returns true if the Log matches the Filter, false otherwise. | ||
| pub fn matches_log(&self, log: &RpcLog<LogData>) -> bool { | ||
| // Check if block option matches |
There was a problem hiding this comment.
let's destructure self here like let Self { a, b, c } = self to make sure we're using all of the fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloese: #1943
Added
matches_logmethod that Adds ability to check if a Log matches a Filter entirely in memory, without requiring RPC calls. This is particularly useful when filtering logs from a single transaction that you already have in memory.@kayabaNerve do you think something like this is what was needed.
PR Checklist