Fix U64 conversion in delta_u64_serde using to::<u64>() instead of as… #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

GarmashAlex wants to merge 1 commit into alloy-rs:main from GarmashAlex:hpp65

+213 −120

GarmashAlex commented Apr 21, 2025

…_u64()

This commit fixes the issue in the delta_u64_serde module where as_u64() method was incorrectly used for converting U64 to u64.

Replaced all instances of as_u64() with to::() in the deserialize function
Updated test expectations in test_delta_u64_serde to match the actual serialization format
Added comprehensive tests to verify serialization consistency of LocalizedTransactionTrace
The fix ensures correct serialization and deserialization of Delta values when used within the RPC trace module.


          Fix U64 conversion in delta_u64_serde using to::<u64>() instead of as…

a4c8785

…_u64()

GarmashAlex requested review from DaniPopes, mattsse, klkvr and yash-atreya as code owners

April 21, 2025 18:34

github-project-automation bot added this to Alloy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

mattsse Awaiting requested review from mattsse mattsse is a code owner

klkvr Awaiting requested review from klkvr klkvr is a code owner

yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet