feat: add ens crate from foundry #2376
Conversation
abhijeetbhagat
requested review from
DaniPopes,
mattsse,
klkvr and
yash-atreya
as code owners
problem is that the ens file needs the |
|
@mattsse hey! what do you think? |
| alloy-contract.workspace = true | ||
| alloy-primitives.workspace = true | ||
| alloy-provider.workspace = true | ||
| alloy-sol-types.workspace = true | ||
| async-trait.workspace = true | ||
| thiserror.workspace = true |
There was a problem hiding this comment.
we can feature gate the async/provider/contract functionality to allow importing just for the utility functions like namehash
the feature should also be re-exported in the meta crate
There was a problem hiding this comment.
let's add this to the meta crate crates/alloy
| #![cfg_attr(not(test), warn(unused_crate_dependencies))] | ||
| #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))] | ||
|
|
||
| pub mod ens; |
There was a problem hiding this comment.
this is unnecessary, we can move everything into lib.rs
Motivation
while working with ENS related stuff, you need utilities like namehash calculation, forward & reverse lookups. these utilities are part of
foundry-commoncrate. developers using alloy-rs as a result require importingfoundry-commoncrate alongside alloy-rs which doesn't make sense since foundry in turn uses alloy-rs as a dependency. (#2372)Solution
we need to provide ENS utilities to developers using alloy-rs by copying the ens crate from foundry with little modifications:
EnsResolverInstancetype to reflect the latest version (foundry uses old version ofalloy-sol-typescrate)inspect_errcall because it in turn callssh_eprintlnwhich belongs to the foundry-common crate.PR Checklist