feat(network): use FullSigner in EthereumWallet to sign data
#2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
changed the title
network): use FullSigner in EthereumWallet to sign hashesnetwork): use FullSigner in EthereumWallet to sign typed data
yash-atreya
changed the title
network): use FullSigner in EthereumWallet to sign typed datanetwork): use FullSigner in EthereumWallet to sign data
mattsse
requested changes
Jun 5, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I think this makes sense,
some nits, can we also send a patch pr to foundry to make sure this doesn't break anything major?
mattsse
approved these changes
Jul 2, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
marking this a blocked for now because breaking, but def something we want to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
EthereumWalletencapsulates adyn TxSignerwhich only gives access to transaction signing capabilities and NOT message / hash signing e.g signing eip712 typed data.Solution
FullSignergives access to both tx sign and message signing.FullSignerin dedicated typeArcFullSignerto disambiguate function calls on the signer that are equivalent but from different traits - e.g the.address(..)exists on bothTxSignerandSignerrequiring fully qualified syntax at callsite by the user, usingArcFullSignertype removes the need for that.ArcFullSignerinEthereumWalletsign_hash_withmethodPR Checklist