Skip to content

chore: update etherscan api urls to v2 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

chore: update etherscan api urls to v2 #174

merged 2 commits into from
Jul 2, 2025

Conversation

iTranscend
Copy link
Contributor

This PR updates etherscan api urls to v2 for v2 supported chains.

resolves #173

required for paradigmxyz/reth#17142

see Etherscan v2 API & v2 supported chains

cc @mattsse

@iTranscend iTranscend changed the title chore: update ehterscan api urls to v2 chore: update etherscan api urls to v2 Jul 1, 2025
@iTranscend iTranscend mentioned this pull request Jul 1, 2025
Merged
mattsse
mattsse reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense now that v1 is basically defunct,

wdyt @grandizzy

@grandizzy
Copy link

this makes sense now that v1 is basically defunct,

wdyt @grandizzy

yep, makes sense!

@grandizzy
Copy link

assets/chains.json needs update too to fix failing tests

@grandizzy grandizzy self-requested a review July 2, 2025 04:18
grandizzy
grandizzy approved these changes Jul 2, 2025
View reviewed changes
Copy link

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@portdeveloper
Copy link

portdeveloper commented Jul 2, 2025 •
edited
Loading

Is it possible to change the Monad Explorer url to this instead? https://testnet.monadscan.com
It is on line 1676 in named.rs and line 1092 in chains.json

I was going to open a new PR but since this is already in the works it made more sense to drop this comment here.

@zerosnacks zerosnacks requested a review from mattsse July 2, 2025 14:33
zerosnacks
zerosnacks approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@zerosnacks zerosnacks mentioned this pull request Jul 2, 2025
Merged
@zerosnacks
Copy link
Member

Is it possible to change the Monad Explorer url to this instead? https://testnet.monadscan.com It is on line 1676 in named.rs and line 1092 in chains.json

I was going to open a new PR but since this is already in the works it made more sense to drop this comment here.

Added in follow-up: #175

@zerosnacks zerosnacks merged commit 063ce98 into alloy-rs:main Jul 2, 2025
20 checks passed
zerosnacks added a commit that referenced this pull request Jul 2, 2025
@zerosnacks
chore: update monad testnet explorer (#175)
3e39a43 
Follow up for: #174, clarify
nightly fmt
@Jds-23 Jds-23 mentioned this pull request Jul 2, 2025
Closed
2 tasks
@zerosnacks zerosnacks mentioned this pull request Jul 3, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update etherscan API urls to v2
5 participants
@iTranscend @grandizzy @portdeveloper @zerosnacks @mattsse