feat: Add Sqlx Traits for Signed Type
#1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvmor
requested review from
DaniPopes,
mattsse and
yash-atreya
as code owners
mattsse
approved these changes
Sep 10, 2025
DaniPopes
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Unsigned a.k.a
U256,U512... types already do impl sqlx Traits which enables crate users to directly pass the said types into sqlx queries,Once I tried to do the same for Signed types I realized that these traits are missing in
sqlxcrate feature, even though the underlying type is the same, so that motivated me to impl these traits.Solution
impl Type, Encode, Decode traits under the sqlx feature that is already existing.
PR Checklist