Revert #1011 #1016
Closed
Revert #1011 #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erives` to periphery SC structs (alloy-rs#1011)" This reverts commit fad2642.
squadgazzz
requested review from
DaniPopes,
mattsse and
yash-atreya
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes from #1011 that added contract-level derive propagation functionality. The revert addresses a compilation bug where derives don't properly propagate to generated internal smart contract structs when SC bindings are generated from ABI JSONs that use other smart contracts internally.
- Removes comprehensive test file for contract-level derives (
derives.rs) - Reverts logic changes in contract expansion that handled derive propagation
- Restores original ordering and positioning of context attribute restoration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/sol-types/tests/derives.rs | Complete removal of test file containing comprehensive tests for all_derives and extra_derives contract attributes |
| crates/sol-macro-expander/src/expand/contract.rs | Reverts derive propagation logic, restores original enum expansion order, and moves context attribute restoration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I was able to find a proper fix for that. Preparing another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #1011 since I was able to reproduce a bug, which block any further code compilation for SC bindings generated from ABI jsons directly that use other SCs internally. Those derives don't propagate automatically to generated internal SC structs. The initial PR will be updated later with a more sophisticated unit test. Apologies for that.