Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sol-macro): expand all getter return types #812

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

DaniPopes
Copy link
Member

Fixes #811

Logic was implemented slightly incorrectly from https://github.com/ethereum/solidity/blob/9d7cc42bc1c12bb43e9dccf8c6c36833fdfcbbca/libsolidity/ast/Types.cpp#L2852

This is a breaking change for the generated return type structs of some mapping getters, but it should be fine since it was incorrect before too

@DaniPopes DaniPopes force-pushed the dani/sol-expand-all-getter-returns branch from d0793cd to 036a26f Compare November 26, 2024 13:24
@DaniPopes DaniPopes merged commit 8a28898 into main Nov 26, 2024
30 checks passed
@DaniPopes DaniPopes deleted the dani/sol-expand-all-getter-returns branch November 26, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] generated getters for storage mappings with dynamic fields can't decode return type
2 participants