Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark Signature as deprecated #819

Merged
merged 4 commits into from
Dec 9, 2024
Merged

chore: mark Signature as deprecated #819

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f382c18
chore: mark Signature as `deprecated`
moricho Dec 5, 2024
f21f64a
fix: put deprecation notice on the struct defs
moricho Dec 5, 2024
51101d2
add `allow(deprecated)`
moricho Dec 5, 2024
f41835d
add `allow(deprecated)`
moricho Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/primitives/src/signature/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ mod error;
pub use error::SignatureError;

mod parity;
#[deprecated(since = "0.8.15", note = "see https://github.com/alloy-rs/core/pull/776")]
pub use parity::Parity;

mod sig;
#[deprecated(since = "0.8.15", note = "use PrimitiveSignature instead")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we put those on the struct defs instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it and added some #[allow(deprecated)]

pub use sig::Signature;

mod utils;
Expand Down
Loading