Skip to content

feat(primitives): add borsh support #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2025
Merged

feat(primitives): add borsh support #993

merged 4 commits into from
Aug 25, 2025

Conversation

mablr
Copy link
Contributor

@mablr mablr commented Aug 22, 2025

Motivation

Close #992

Solution

  • Added borsh as a dependency in Cargo.toml files for the main crate and primitives.
  • Implemented borsh serialization and deserialization macros in the primitives library.
  • Implemented borsh serialization and deserialization for FixedBytes

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mablr
feat(borsh): add borsh serialization support to primitives
6afeee7 
- Added borsh as a dependency in Cargo.toml files for the main crate and primitives.
- Implemented borsh serialization and deserialization macros in the primitives library.
- Implemented borsh serialization and deserialization for FixedBytes
mablr
mablr commented Aug 22, 2025
View reviewed changes
Copy link
Contributor Author

@mablr mablr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also implement Bytes ?

@mablr mablr changed the title feat(borsh): add borsh serialization support to primitives feat(primitives): add borsh serialization support to primitives Aug 22, 2025
@mablr mablr changed the title feat(primitives): add borsh serialization support to primitives feat(primitives): add borsh support Aug 22, 2025
mattsse
mattsse requested changes Aug 22, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, ty

one nit re feature activation

pending @DaniPopes

@github-project-automation github-project-automation bot moved this to In Progress in Alloy Aug 22, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Reviewed in Alloy Aug 22, 2025
@mattsse
Copy link
Member

mattsse commented Aug 22, 2025

Should we also implement Bytes

ah yes we should actually

@mattsse
Copy link
Member

mattsse commented Aug 22, 2025

@mablr to fix ci

32 | let mut out = Vec::new();
| ^^^ use of undeclared type Vec

we need to import alloc::vec::Vec manually

@mablr mablr mentioned this pull request Aug 22, 2025
Open
@mablr mablr requested a review from mattsse August 23, 2025 21:39
DaniPopes
DaniPopes approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes DaniPopes merged commit db374d9 into alloy-rs:main Aug 25, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in Alloy Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@yash-atreya yash-atreya Awaiting requested review from yash-atreya

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Alloy
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Add borsh support

3 participants

@mablr @mattsse @DaniPopes