feat(sol-macro-expander): add name_by_selector method for enum variant retrieval
#995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant retrieval - Implemented a new method `name_by_selector` in the `CallLikeExpander` to return the enum variant name based on a given selector. - Added unit test
DaniPopes
reviewed
Aug 24, 2025
DaniPopes
reviewed
Aug 24, 2025
…tion signature retrieval - Implemented a new method `signature_by_selector` to return the function signature based on a given selector. - moving `VARIANT_NAMES` and `SIGNATURES` to impl to make them public - Updated the `name_by_selector` method to utilize the new signature retrieval - Added unit tests for the new functionality in `signature_by_selector_basic`
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
DaniPopes
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #994
Solution
name_by_selectorto return the enum variant name based on a given selector.PR Checklist