feat: change return type of formatConfigurationPayload

alma · Oct 21, 2024 · 8ed5363 · 8ed5363
1 parent 4b9ab73
commit 8ed5363
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/src/Lib/PayloadFormatter.php b/src/Lib/PayloadFormatter.php
@@ -10,16 +10,14 @@ class PayloadFormatter
 	/**
 	 * @param CmsInfo $cmsInfo
 	 * @param CmsFeatures $cmsFeatures
-	 * @return string
+	 * @return array
 	 */
 	public function formatConfigurationPayload(CmsInfo $cmsInfo, CmsFeatures $cmsFeatures)
 	{
-		$payload = [
+		return [
 			"cms_info" => $cmsInfo->getProperties(),
 			"cms_features" => $cmsFeatures->getProperties(),
 		];
-
-		return json_encode($payload);
 	}
 
 }
diff --git a/tests/Unit/Lib/PayloadFormatterTest.php b/tests/Unit/Lib/PayloadFormatterTest.php
@@ -54,13 +54,13 @@ public function testFormatIntegrationConfigurationPayload()
 		$result = $this->payloadFormatter->formatConfigurationPayload($cmsInfo, $cmsFeatures);
 
 		// Expected result in JSON format
-		$expectedPayload = json_encode([
+		$expectedPayload = [
 			'cms_info' => $cmsInfo->getProperties(),
 			'cms_features' => $cmsFeatures->getProperties(),
-		]);
+		];
 
 		// Assertion: Check if the output matches the expected JSON payload
-		$this->assertJsonStringEqualsJsonString($expectedPayload, $result);
+		$this->assertEquals($expectedPayload, $result);
 	}
 
 	public function testFormatIntegrationConfigurationPayloadWithEmptyValues()
@@ -101,12 +101,12 @@ public function testFormatIntegrationConfigurationPayloadWithEmptyValues()
 		$result = $this->payloadFormatter->formatConfigurationPayload($cmsInfo, $cmsFeatures);
 
 		// Expected result in JSON format (should not include keys with null or empty values)
-		$expectedPayload = json_encode([
+		$expectedPayload = [
 			'cms_info' => $cmsInfo->getProperties(),
 			'cms_features' => $cmsFeatures->getProperties(),
-		]);
+		];
 
 		// Assertion: Check if the output matches the expected JSON payload
-		$this->assertJsonStringEqualsJsonString($expectedPayload, $result);
+		$this->assertEquals($expectedPayload, $result);
 	}
 }