Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: L1 tx batcher #20

Merged
merged 3 commits into from
Nov 14, 2024
Merged

feat: L1 tx batcher #20

merged 3 commits into from
Nov 14, 2024

Conversation

Zk2u
Copy link
Collaborator

@Zk2u Zk2u commented Nov 13, 2024

replaces per request transactions for faucet with a background task that batches faucet withdrawals

Todo

  • batch config in toml config file
  • reasonable max limits to number of payout requests in memory queue + prealloc

closes STR-612

@Zk2u Zk2u added enhancement New feature or request rust Pull requests that update Rust code labels Nov 13, 2024
@Zk2u Zk2u requested a review from storopoli November 13, 2024 13:31
@Zk2u Zk2u self-assigned this Nov 13, 2024
@Zk2u Zk2u marked this pull request as draft November 13, 2024 13:32
@Zk2u Zk2u marked this pull request as ready for review November 13, 2024 14:17
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.
Looks good, thanks!

ACK b2bb0ff

Feel free to merge if you want or make changes.

src/l1.rs Show resolved Hide resolved
src/batcher.rs Show resolved Hide resolved
src/batcher.rs Show resolved Hide resolved
src/batcher.rs Show resolved Hide resolved
src/batcher.rs Show resolved Hide resolved
@Zk2u Zk2u merged commit 75a66ad into main Nov 14, 2024
6 checks passed
@Zk2u Zk2u deleted the feat/batcher branch November 14, 2024 16:35
Comment on lines +47 to +49
/// Creates a new `Batcher`.
/// You should call `Batcher::start` after this to start the batcher task,
/// otherwise the batcher won't do anything.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been doclinked but it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants