Propose accessibility fixes for enhanceSelectElement #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for accessible-autocomplete ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Noticed this is in draft, I provided a custom approach here, hope it helps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These proposed changes would fix the following two issues
#589
#752
#592
these are something that hmrc services get asked to fix in accessibility audits so the services have to patch their usages with some js, we've been investigating how to roll the fixes into hmrc-frontend to save services having to add it themselves, but it seems like the fixes would be quite simple to make here so thought we'd propose them upstream just in case it's useful
(apologies I didn't realise that a deploy preview could be done for external contributions so I didn't regenerate the dist version so the deploy preview doesn't include the fix so you can't actually try it out there)