MVP: gather data and metadata #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
force-pushed
the
process-all-data
branch
from
a2a8ae6 to
f27f2f5
Compare
domoscargin
force-pushed
the
process-all-data
branch
4 times, most recently
from
f732207 to
5f7b5c0
Compare
owenatgov
commented
Jan 9, 2025
There was a problem hiding this comment.
Reviewing my own PR since @domoscargin did loads of work on it.
I've left one comment, otherwise this is looking good, especially with the context of #20 getting a review once this one's in. Also world be keen to clean up the commit history if poss.
.github/workflows/update.yml
Outdated
| @@ -43,7 +47,8 @@ jobs: | |||
| # github action which doesn't give us the option to output this data as | |||
| # something like json which we can programmatically interogate. | |||
| - name: Pipe our deps to a json file | |||
| run: github-dependents-info --repo alphagov/govuk-frontend --sort stars --json > raw-deps.json | |||
| run: npm -v | |||
| # run: github-dependents-info --repo alphagov/govuk-frontend --sort stars --json > ./data/raw-deps.json | |||
There was a problem hiding this comment.
We can put this back now that we're done testing!
domoscargin
force-pushed
the
process-all-data
branch
from
cde51fb to
7e03cd7
Compare
|
@owenatgov I've hacked way at the commit history - not sure if you want to do anything to #6318865 other than reword it? |
Adds a base head_ref, and gives the action contents:write permission
I've had to pop some Babel foo on top of eslint because we're using import assertions.
Uses the repo's `created_at` and `pushed_at` properties.
We were just writing to a JSON file, but CSV is more useful for other folks who want to use the data.
owenatgov
force-pushed
the
process-all-data
branch
from
7e03cd7 to
15c58a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables:
Also creates a PR with the latest data once the script has finished running.
As the basic functionality works, I'm marking this ready for review, and adding issues to describe further work.