WIP: workflow #1771
Draft
WIP: workflow #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-Hunt
force-pushed
the
review_apps_pr_workflow
branch
4 times, most recently
from
f64f9bd to
5a5f5d8
Compare
AP-Hunt
force-pushed
the
review_apps_pr_workflow
branch
from
5a5f5d8 to
436d29f
Compare
AP-Hunt
force-pushed
the
review_apps_pr_workflow
branch
7 times, most recently
from
0278ec3 to
6af3fe0
Compare
Refactors the review apps GitHub Actions workflow to build the container image on a hosted GitHub Actions runner, to take advantage of the image caches.
AP-Hunt
force-pushed
the
review_apps_pr_workflow
branch
from
9b176fc to
99d5e3c
Compare
We removed the dependency on factory bot for seed data, so we no longer need to install it inside the container before starting up.
When the PR closes (either by merging, or closing withotu merging), the review app needs to be cleaned up.
Once a deployment is complete, we want to leave a comment on the PR telling them where to find the review app.
AP-Hunt
force-pushed
the
review_apps_pr_workflow
branch
from
d0a425e to
ab50b2c
Compare
* Add label to enable Traefik basic authentication * Credentials are configured in forms-deploy
We were previously using the Postgres 13.12 image from docker.io, but we routinely hit issues with being rate limited by it. To avoid that, we use Amazon's own registry, which contains mirrored images from docker.io, without rate limits.
sarahseewhy
force-pushed
the
review_apps_pr_workflow
branch
from
d6bd7ae to
60a1bed
Compare
…-review-app job When we built it in a separate job, we found that the container was faulty in some way. In forms-deploy we have now configured CodeBuild to have Docker Hub credentials, so the rate limits are not a concern anymore.
We want to make sure that the tag applied to the container being built in the workflow is unique on each run, so that a re-run of a failed workflow will result in a new container. There are many reasons for failure, and sometimes we want the container to be built afresh.
AP-Hunt
force-pushed
the
review_apps_pr_workflow
branch
from
60a1bed to
965cc9b
Compare
In Traefik's configuration model, middlewares must be explicitly attached to routers. We had not done that.
* Point Forms API base URL to localhost and configured port (9292) since tasks share the same network
* Use `html_url` which is the human readable version, `url` points to the GitHub API friendly URL * Add link to review app URL
|
|
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1771.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card:
Things to consider when reviewing